Safari 13.1 fix #129
Merged
Safari 13.1 fix #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
approved these changes
Apr 10, 2020
|
Also, the test suite seems to only be happy with node 10, so I'm adjusting the Travis CI config to force that version. From what I can tell, that's all due to I don't think the actual runtime node version requirements are any different, but it is harder to confirm that without a test suite that runs in those versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
CC: @gauntface (not sure how involved you want to be at this stage)
C.f. GoogleChrome/workbox#2444 (comment)
This disables a workaround that was in place for Safari 12 compatibility. That workaround breaks things in Safari 13 (well, Safari 13.1 at least), so I changed the workaround logic so that it checks for a major version number of
12.I also bumped up the
selenium-webdriverdependency to^4.0.0-alpha.7from^4.0.0-alpha.4.I figure that this sort of thing warrants a minor semver change, so the
package.jsonversion was increased to6.1.0.